Check files affected by task contribution Pull Requests #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rafael Oliveira <[email protected]>
This ensures that task contribution proposal/submission content is identical in the pull request description and the affected README.md file, so that reviewers can have confidence that they need only check one of them without comparing against the other.
RafDevX
commented
Oct 13, 2024
|
Sorry, it's exam season - I'll take a look ASAP today or tomorrow. |
|
No problem! Thanks for letting me know! |
Since we check that the PR description matches the affected README file, we need to repeat this check if the description ever changes. Note that the GitHub default for if no types are specified is "opened", "reopened", and "synchronize" -- so this commit only adds "edited", in practice.
algomaster99
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2583
This pull request checks whether any contributions match the norm of what is expected of a task proposal/submission:
README.mdand in a reasonable location; and