Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final submission for open source contribution: Contributing to DevOps-exercises #1896

Merged
merged 8 commits into from
May 6, 2022

Conversation

Akseluhr
Copy link

@Akseluhr Akseluhr commented May 3, 2022

Assignment Proposal

Title

Contributing to devops-exercises

Names and KTH ID

Deadline

Task 3

Category

Contribution to open-source

Description

devops-exercises contains questions and exercises on various technical topics, related to DevOps.

We found that there were no questions about software supply chain and dependecny management, two highly relevant fields of DevSecOps. Therefore, we want to contribute with questions related to the mentioned fields. Our aim is to read research papers and documentation related to the topics and then formulate relevant questions and answers for this open source repo.

As of today, the repo has 22.5k stars, and is actively managed by more than 80 contributors. We have had initial discussions with the owner of the repo who are welcoming our idea.

Final Submission for open source contribution

Pull request can be found here: bregman-arie/devops-exercises#229

All questions can be found here including answers:
https://docs.google.com/document/d/1j7vk94A7epkQvlB6b8qpqjcYIGSG0t9jsffEl8nQq-I/edit?usp=sharing

We opened a PR and had a nice discussion with the repo owner. On the first PR, we got some constructive feedback which we acted upon and modified our contribution accordingly. We hope that our contribution will be merged soon.

@javierron javierron self-assigned this May 6, 2022
@javierron javierron added final_submission The final submission of a task contribution_to_opensource One of the task categories listed in README.md labels May 6, 2022
@javierron
Copy link
Collaborator

@Akseluhr Thanks for the submission!

To be able to merge, the merge conflict must be fixed first. Thanks!

@Akseluhr
Copy link
Author

Akseluhr commented May 6, 2022

Should be fixed now @javierron have a nice weekend.

@javierron javierron merged commit 64ba9ca into KTH:2022 May 6, 2022
@Akseluhr
Copy link
Author

Hi @javierron we're just wondering whether something is missing for the grade although it is merged here?

regards
Aksel & Abdullah

@bbaudry
Copy link
Collaborator

bbaudry commented May 20, 2022

@Akseluhr You have contributed interesting questions and have had a good conversation with the lead dev of the project. It is important that your PR is merged in order for you to pass the task. What is missing to get bregman-arie/devops-exercises#229 merged?

@Akseluhr
Copy link
Author

Hi @bbaudry thanks for the comment. We have iteratively made changes w.r.t. the lead dev's feedback and our discussion. Last changes from our side was committed 4 days ago and it has not been reviewed yet. What has happened is that we kept getting new feedback iteratively for the answers and questions we wrote (that is - not all feedback at once, see the PR linked in the readme for clarification). So the reviewing process for merging has taken longer than expected.

We hope that we will "pass" his checks with our most recent commit. Not sure when he has time though.

@Abdullah1428
Copy link

@bbaudry our PR is now merged after passing all the checks. hopefully it can be graded now. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution_to_opensource One of the task categories listed in README.md final_submission The final submission of a task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants