Check user profile field lengths #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Type: Bug
Area: Backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The server recently had to be restarted with lots of this in the log:
Cause
The database only allows 10000 characters for user descriptions.
SpaceDock/KerbalStuff/objects.py
Line 69 in dbd6722
But the Python code just passes whatever it receives, and some spammer tried to create a user description that was too long. Somehow this seems to have confused gunicorn into repeating the attempt and taking up lots of CPU. Auto retry somehow?
Changes
Now the profile save code check the lengths of the inputs before using them, and if any exceeds their limits, it aborts. Similar to a side fix in #357 for mod editing.
Fixes #469.