Escape user-edited fields in OpenGraph meta tags #415
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Causes
ChainedUndefined
(see Handle missing default mod version, don't close db before rendering templates #378) makes properties safe but not methods, and Add OpenGraph meta tags #385 addedlatest.created.strftime()
Changes
escape
filter is applied to each instance of user-edited text in theog:
meta tags, which will prevent them from terminating the attributes.bleach
was mangling the text in a way that preventedescape
from working, so I replacedbleach
instead of combining them.latest
isNone
, we skip the whole first line of the mod description and just returnMod.short_description
by itselfog:image
rather than/static/og.png
Fixes #407.