Fix attribute error when saving mod that was in deleted modpack #380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Cause
In #368 we added some code that assumes that
ModListItem.mod_list_id
won't be NULL.SpaceDock/KerbalStuff/search.py
Line 28 in 453f8d5
However, when you delete a mod list, its
ModListItem
s are not deleted but simply have theirmod_list_id
set to NULL.Each such row represents a case where
Mod.mod_list_items[X].mod_list
isNone
for some mod.Changes
ModListItem
s from deleted mod lists are deletedModListItem.mod_id
is non-nullable and has cascade deletion enabledModListItem.mod_list_id
is non-nullable and has cascade deletion enabledModListItem.sort_index
is non-nullableAfter this, the code from #368 will be correct that
ModListItem.mod_list_id
won't be NULL.