Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lingering fuel information after opening/closing the PAW and removing/adding engines #255

Closed
daantimmer opened this issue Mar 26, 2021 · 1 comment · Fixed by #256
Closed

Lingering fuel information after opening/closing the PAW and removing/adding engines #255

daantimmer opened this issue Mar 26, 2021 · 1 comment · Fixed by #256

Comments

@daantimmer
Copy link

I've got an issue with fuel tanks and RealFuels where the information from a previously added engine lingers in the PAW, but only after looking at the PAW.

I've made a video explaining it all in more detail:
https://gfycat.com/distantgiftedaztecant

If you add/remove engines while not looking at the PAW then the information doesn't stick around. The 'Show Tank' GUI is fully up to date however and doesn't show old information.
The buttons to add fuel in the PAW actually work with setting the "incorrect" fuel.
@daantimmer
Copy link
Author

Forgot to add:
KSP 1.10.1
Real Fuels rf-v12.9.0.1

DRVeyl added a commit to DRVeyl/ModularFuelSystem that referenced this issue Mar 27, 2021
@DRVeyl
Handle PAW Field Caching
4da4928 
Fixes KSP-RO#255
KSP after 1.8 is cacheing more PAW fields.  In 1.10, the created event buttons hang around and don't get cleared by PAW creation, only by refresh.  Catch the PAW show event and request a refresh if one is requested.
Refactor UpdateUsedBy a little.  Every tank PartModule iterating over every vessel PartModule to build the UsedBy mapping may need analysis
@DRVeyl DRVeyl mentioned this issue Mar 27, 2021
Merged
@DRVeyl DRVeyl mentioned this issue Apr 11, 2021
Open
RCrockford pushed a commit that referenced this issue Apr 16, 2021
@DRVeyl
Handle PAW Field Caching (#256)
2d6ba2a 
Fixes #255
KSP after 1.8 is cacheing more PAW fields.  In 1.10, the created event buttons hang around and don't get cleared by PAW creation, only by refresh.  Catch the PAW show event and request a refresh if one is requested.
Refactor UpdateUsedBy a little.  Every tank PartModule iterating over every vessel PartModule to build the UsedBy mapping may need analysis
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Handle PAW Field Caching DRVeyl/ModularFuelSystem
1 participant
@daantimmer