Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add North Kerbin Dynamics Renewed-Extended (NKDR-E) from SpaceDock #9909

Merged
merged 4 commits into from
Feb 11, 2024

Conversation

netkan-bot
Copy link
Member

This pull request was automatically generated by SpaceDock on behalf of josue, to add North Kerbin Dynamics Renewed-Extended (NKDR-E) to CKAN.

Please direct questions about this pull request to josue.

Mod details

Key Value
Name North Kerbin Dynamics Renewed-Extended (NKDR-E)
Authors josue
Abstract Your favorite nukes are back for BDA+
License CC-BY-SA
Size 68.09 MiB
Homepage <>
Source code https://github.com/josuenos/NKDR/

Description

Extending the life of a BDA weapons mod favorite, revamped for compatibility with BDArmory Plus (BDA+). Mod requires BDA+.

Thanks to KingNoob1337 for updating almost all the configs for compatibility with BDA+ and harpwner for creating NKD and cukkoo for NKDR.

This is an automated commit on behalf of josue
@JonnyOThan
Copy link
Contributor

JonnyOThan commented Feb 9, 2024

Hi @josuenos, and maybe @BrettRyland - Have you reached out to @dogevspenguin regarding possibly replacing the existing NKDR on CKAN?

I think that would be the best situation for CKAN users, because otherwise they would be faced with a choice between two similarly named mods that both appear to be compatible with the commonly-accepted game versions 1.8-1.12.

If you'd prefer to go ahead and add it anyway, that's fine. And if you do reach out and don't hear anything back within a reasonable amount of time, we could still replace the older one (under the assumption that it's abandoned). But it's cleaner to do the replacement when the mod is first added to CKAN.

If replacement is something you're interested in, I can help edit the metadata to do that.

@BrettRyland
Copy link

Josue is the main contact for this one, so I'll leave such decisions to him. However, I think that if NKDR-E were to replace NKDR, then anyone wanting to use NKDR with BDAc (for multiplayer support or some other reason) would quickly run into dependency issues since NKDR-E depends on BDA+.

@JonnyOThan
Copy link
Contributor

Ok that's a good reason to keep both of them. Thanks for the info.

@JonnyOThan JonnyOThan merged commit 503b73a into master Feb 11, 2024
1 check passed
@JonnyOThan JonnyOThan deleted the add/NorthKerbinDynamicsRenewedExtendedNKDRE branch February 11, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants