Update KerbalAircraftExpansion.netkan #2863
Conversation
Adding Epoch to fix new version sorting and install example craft now that we can do that. Other exclusions have been removed from download.
|
See also KSP-CKAN/CKAN-meta#911 |
|
From what I see, we're already offering the correct version |
|
The Max KSP is listing as 1.0.4, though. |
|
Oh I see what you're talking about: we have a 1.0.5-compatible version but the "Max KSP Version" column incorrectly displays the compatibility from a previous version. Basically this is KSP-CKAN/CKAN#1327 emerging again. We should probably disable that column until the issue is resolved. I'll merge this and KSP-CKAN/CKAN-meta#911 as a bandaid fix (once we sort out the technical errors in the PRs). |
|
Yep. I've been steadily working through applying bandaids for that issue. |
| }, | ||
| { | ||
| "find": "Example Craft", | ||
| "install_to": "Ships/SPH" |
There was a problem hiding this comment.
This will not work as we cannot create Ships/SPH/Example Craft/. .craft files must be installed directly to Ships/SPH/. Thus we filter the Example Craft.
There was a problem hiding this comment.
Oh. I thought it would just install the files from that directory into Ships/SPH.
I guess we'll need to use "find_matches_files" : "true", and make it a find_regexp "Example.Craft.*craft". I'll test it.
There was a problem hiding this comment.
Damn. I can't test it. My netkan keeps getting authentication errors.
|
Instead of bandaid epoch bumps that make version numbers harder to discern for users and contributors alike, I'd much rather fix the problem with the column itself, disabling it in the interim if necessary. Realizing now what all your previous PRs were doing I wish I had rejected them and disabled the column from the start. |
|
They aren't all for that reason. |
Can someone test this?
|
Well, that find_regexp works partially. It only installs one of the Example Craft, but correctly puts the craft file into the SPH folder. Looks like we have to do separate finds for each craft. I'm surprised that setting find_matches_files true doesn't allow multiple files with a find_regexp. |
|
I do think that an epoch bump is called for when a modder changes the version string system they use, which keptin has certainly done in this case. |
Remove Example Craft install
|
Ok, I've reverted the Example Craft installation and will make that a separate change (if I can get it working in a sane way) |
|
Spec_ver increase limits CKAN version compatibility unnecessarily and the added |
|
Thanks. |
Adding Epoch to fix new version sorting and install example craft now that we can do that. Other exclusions have been removed from download.