Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Sort By Download Size, Doesn't #6611

Closed
StevenBarden opened this issue Jul 1, 2018 · 7 comments
Closed

The Sort By Download Size, Doesn't #6611

StevenBarden opened this issue Jul 1, 2018 · 7 comments

Comments

@StevenBarden
Copy link

StevenBarden commented Jul 1, 2018

I'm sure you know by now, but it's sorting alphabetically, an easy switch in C#. Ty.

Background

CKAN Version:
1.24.0

KSP Version:
1.4.4.2215

Operating System:
Win10 Corp-thing on awarded HPZ15 w/ 32 gigs mem and stick-version sshd with enough room

Have you made any manual changes to your GameData folder (i.e., not via CKAN)? WHY, ARE YOU NOT USING LIBRARIES TO SPEAK TO IT? lol, j/k. I've messed with config files trying to replace whatever setting I mussed up where phrases all over the screen are showing up as #autoLOC_000000 (I loved the autocomplete that just showed up when I pressed #, and ironically, right out of the Dictionary.cfg that my game won't read, and i should type this elsewhere, oops)

Affected mods and mod versions:
The view of all Mods is temporarily modified in the first two clicks on the header, and then stops, regardless of the efforts to click the sort as Up or Down, which does shift, making the problem all the odder. All mods in view in view by the appearance, but again, just view and sort, not in functionality, that I see.

Again, (in my experience) once the Download column is sorted on the first click, it will not move again, indicating an incorrect configuration. If you scroll down the page and click to sort, your view of the list is restarted at the top, but the sort of the list never changed after the first two clicks.

I was going to add that it does not differentiate between KB and MB, but I see it simply sorts in the name column... rather, in the two-click start, it sorts with Name, which sorts Ascending (A->Z) and does not switch when the Download column is clicked again.

Problem

What steps did you take in CKAN?
I wanted to sort by mod-download-size and clicked on the column header, in a few ways before I wrote this, and oddly, even more, once I started writing this (I really just wanna ask for code and break out visual studio, i love this tool, lol).

What did you expect to happen? that the mods would sort by size INCLUDING THE FACT THAT
1.0 MB = 10 KB thinking this will be accounted for (or use one scale... sorry... back to...)

What happened instead?

Screenshots:

CKAN error codes (if applicable):

@HebaruSan
Copy link
Member

HebaruSan commented Jul 1, 2018

Thanks for the report. This was originally reported on the forum, fixed in KSP-CKAN/CKAN#2311.

Download the latest release for the fix.

@StevenBarden
Copy link
Author

I apologize for taking your time with this. Thank you.

@HebaruSan
Copy link
Member

No apology needed, thanks for taking the time.

@StevenBarden
Copy link
Author

StevenBarden commented Jul 1, 2018 via email

@HebaruSan
Copy link
Member

  1. Localization problems
    Sorry, I don't know what would cause that (and I don't know which script you're referring to), other than it sounds like some of the stock game files are messed up. If this happened to me, I think I would try checking the integrity of the stock game files to restore them to their pristine state. Steam has an easy way to do this, but if you don't have Steam, simply reinstalling the game might be enough.

  2. S.A.V.E. mod file format
    I also don't know the answer to this one, since I haven't tried that mod. I would recommend asking on the forum thread for that mod. Either the mod author or some of the other users should be able to explain how it works.

  3. Installation timestamp suggestion
    I think that idea is on file somewhere here:

  4. Hold checked state / ACID test
    Sounds like this is all about losing changes if there's a problem with an install? It sounds like a good idea in the abstract, but I'm not sure how it would be implemented in practice. (And whenever possible, I'd prefer to fix a crash rather than working around it.)
    Please feel free to submit a more detailed enhancement suggestion: https://github.com/KSP-CKAN/CKAN/issues/new

  5. You helping
    Of course! CKAN is open source and MIT-licensed and welcomes contributions and pull requests here on GitHub. There are several wiki pages that are intended to help with getting started:

    You don't even need to be an official member to get started. I personally submitted several small code fixes before being formally invited to join, and that route remains open to anyone interested.

@StevenBarden
Copy link
Author

StevenBarden commented Jul 2, 2018 via email

@StevenBarden
Copy link
Author

StevenBarden commented Jul 2, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants