Clarify remote swinfo network errors #3843
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
#3817 added retrieval of remote
swinfo.json
files for KSP2 mods, which are very analogous to remote version files.Problem
If the
version_check
property contains a URL that's a broken link, the error message isn't clear. It's just a generic 404 error that could be coming from anywhere:Changes
Now that exception is caught and replaced with one indicating the context in which the error occurred:
I might self-review this since it only affects the bot and would be nice to have soon-ish.