Make grid ampersand workaround platform specific #3807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techman83
approved these changes
Mar 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Originally, mod names, abstracts, and authors containing
&characters would have them removed and the next character underlined on Mono:#3149 fixed that by escaping the ampersands, which is done by adding another one.
Problem
Windows clients currently see
&&in the grid:Cause
.NET is cross-platform in principle, but not quite "write once run anywhere" in practice. Whenever Mono deviates from how .NET does something, pain ensues for application developers. In this case, Mono treats
&as a hotkey prefix character in the data grid view, but .NET treats it as just a normal character.Changes
Now we only double the ampersand on Mono. Windows gets the single ampersand and likes it:
Fixes #3806.