Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort Netkan warning lists #3492

Merged
merged 1 commit into from
Dec 4, 2021
Merged

Conversation

HebaruSan
Copy link
Member

Problem

It was a surprise to see this for an established mod that probably isn't changing much from one release to the next:

image

It seems like the warning should remain the same and therefore not be sent to Discord.

Cause

Same files, different order. The order of the list in the message depends on the order in the ZIP file, so if a succession of releases has the same warnings but the ZIP is created slightly differently, we get extra warning messages sent to Discord:

image

This could happen for any warning that contains a list of multiple things.

Changes

Now the following messages are sorted alphabetically. This will probably cause a one-time cascade of new warnings sent to Discord as they all switch over to the proper sorted order:

  • Multiple version files
  • Craft files in wrong path
  • Found copies of the Harmony DLL
  • Paths with GameData contained in GameData
  • Attempts to install same paths multiple times
  • Config files using ModuleManager syntax without ModuleManager depends
  • DLLs not matching the identifier for detecting manual installs

Also the localizations property will now be in alphabetical order. This might cause a large number of one-time re-indexings.

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix Pull request Netkan Issues affecting the netkan data labels Dec 2, 2021
@HebaruSan HebaruSan requested a review from DasSkelett December 2, 2021 16:23
Copy link
Member

@DasSkelett DasSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would've never thought that files in zips could be unsorted 😄
But it makes sense, it just packs whatever you pass it.

Sorted localizations make a lot of sense as well (a bit unrelated: we should consider sorting the list in our GUI language selection dropdown as well)

@HebaruSan HebaruSan merged commit 9607b5d into KSP-CKAN:master Dec 4, 2021
@HebaruSan HebaruSan deleted the fix/netkan-warn-sort branch December 4, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Easy This is easy to fix Netkan Issues affecting the netkan data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants