Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release date column #3096

Merged
merged 1 commit into from
Jul 1, 2020
Merged

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jul 1, 2020

Motivation

One of my earliest memories of chatting on the CKAN thread is suggesting that a release date column shouldn't be that hard to add:

This is a pretty popular request and would allow users to see which mods have been updated recently. Here's another time it came up:

Background

After #3059 the Netkan Inflator has collected a full round of release date metadata from GitHub and Jenkins, and SpaceDock is in progress pending the next run of the webhooks only pass. The only thing left is the UI.

Changes

Now a new sortable "Release date" column appears in GUI, so users can tell how recently mods were updated.
I attempted a German translation with Google Translate.

Fixes #1155.
Fixes #1766.
Closes #2916.

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Pull request labels Jul 1, 2020
@HebaruSan HebaruSan requested a review from DasSkelett July 1, 2020 05:57
@HebaruSan HebaruSan force-pushed the feature/release-date-col branch from 92c7dc0 to 7df6b49 Compare July 1, 2020 06:04
@techman83
Copy link
Member

This is really awesome, thanks for all your hard work and persistence with this @HebaruSan! (Added an edit for the proposal for the new field).

Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems like a sensible set of changes from my initial glance over the code.

@HebaruSan HebaruSan merged commit a39045f into KSP-CKAN:master Jul 1, 2020
@HebaruSan HebaruSan deleted the feature/release-date-col branch July 1, 2020 06:30
@DasSkelett DasSkelett added the i18n Issues regarding the internationalization of CKAN and PRs that need translating label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features or functionality GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Proposal] Release Date Add "Updated" filter type column for date mod updated
3 participants