Only stage auto-epoch when creating new file #2947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Easy
|
Code-wise it looks fine. Though I'm thinking whether we should add a |
|
Good idea, added. |
DasSkelett
approved these changes
Jan 7, 2020
HebaruSan
added a commit
that referenced
this pull request
Jan 7, 2020
|
I'm not finished my coffee. How does netkan know there is a new or existing file? |
|
If the file is new, its version will be higher than the highest version. (If it's lower, it will be auto-epoched until one of the above is true.) |
|
Ok Cool! Makes sense 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A lot of auto-epoching pull requests have been updates for versions that were created in previous PRs, see KSP-CKAN/CKAN-meta#1621 and KSP-CKAN/CKAN-meta#1694 for an example. In this case we have already confirmed in the first PR that the version should exist, so manual review isn't needed for later ones.
Changes
Now we only enable staging if the resulting version after auto-epoching is greater than the previous highest version. If we're updating a version that already exists, staging isn't needed.