Save restore position when minimized #2725
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you:
... then the following is saved to
GUIConfig.xml
:And the next time CKAN runs, its window will not appear.
Cause
Apparently Windows moves minimized windows to (-32000,-32000).
https://stackoverflow.com/questions/1478765/location-coordinates-on-computer-showing-x-32000-y-32000
So when we exit and save the
Location
property while minimized, we're saving that value.Changes
Now we ignore
Location
if the window state isn't normal (i.e., we're minimized or maximized), and instead we checkRestoreBounds.Location
, which is where the window's former location to which it will be returned lives. This mirrors how we handle the window size on the next line of code (though in that case the problem was with maximization).Fixes #2717.