Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right click copy option for mod info links #2699

Merged
merged 3 commits into from
Apr 21, 2019

Conversation

HebaruSan
Copy link
Member

Motivation

It may sometimes be desirable to access a mod's home page URL without opening it in the default browser, for instance you might want to open it in another browser or paste it into a forum post.

Currently right clicking the links works just like left clicking, the URL is opened in the system default browser.

screenshot

Changes

Now if you right click one of the mod info links, a context menu appears with a "Copy link address" option. Clicking this option copies the URL to the clipboard.

image

Fixes #2698.

@HebaruSan HebaruSan added Enhancement New features or functionality GUI Issues affecting the interactive GUI Pull request labels Mar 16, 2019
@DasSkelett
Copy link
Member

DasSkelett commented Apr 16, 2019

Good news, works on Windows :D
image
What about adding it to the link labels in the About dialog?

@HebaruSan HebaruSan added the In progress We're still working on this label Apr 17, 2019
@HebaruSan
Copy link
Member Author

Rebased and added About window support.

@HebaruSan HebaruSan removed the In progress We're still working on this label Apr 17, 2019
@HebaruSan HebaruSan merged commit d31a98f into KSP-CKAN:master Apr 21, 2019
@Olympic1 Olympic1 removed Enhancement New features or functionality Pull request labels Apr 21, 2019
@HebaruSan HebaruSan deleted the feature/copy-link branch April 21, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy / drag&drop for mod links (Feature Request)
3 participants