-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customisable columns in GUI Modlist #2690
Customisable columns in GUI Modlist #2690
Conversation
Let's remove the update/replace columns from the menu since we're managing them automatically. |
I'm going to set the |
c5105d0
to
41d9328
Compare
Removed the buttons for the first three columns in the context menu. |
This looks pretty good. Created DasSkelett#3 with some code style and UI ideas. |
41d9328
to
c01947c
Compare
For the record: @HebaruSan's suggestions are merged and included. Thanks :) |
DasSkelett#4 created with a suggestion for the config. |
…mn (#4) * Save/load column names instead of list of bools * Remove auto-managed columns from default config list * Save/load hidden columns instead of visible * Rename col vis config func By @HebaruSan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My favorite part of this is the hiding of the update/replace columns when they're not needed.
This PR adds the option to hide columns in the modlist. as asked by @politas in #2687.
This happens via a right click context menu on the header row of the modlist:

The columns are hidden with
column.Visibility = false
, which seems to work perfectly fine in my testing. This doesn't need a reload of the modlist or anything, so it's fast.On every change of the visibility of a column it is saved to the GUIconfig, which means it's persistend across ckan restarts.
The
Update
and theReplace
checkbox columns are hidden by default, and only shown if an update / a replacement is available. I could only test updates yet, but replacements should work the same.Once all updates / replacements have been done, the columns are hidden again.
This all happens in
UpdateModsList()
.Furthermore, the
Installed version
and theInstall date
columns are hidden with theNot Installed
filter setting selected, there's no sense in showing them. This happens without a GUIconfig change, so once the filter is changed again, those two columns reappear (or stay hidden) based on the previous setting.Closes #2687
Small sidefix: if you right-clicked on the modlist header bar before, the context menu for the mod rows opened, despite it shouldn't. It's fixed now by not assigning
ModList.ContextMenuStrip = ModListContextMenuStrip
. Instead, the new column selection menu opens, obviously.