Confirm quit with pending change set or conflicts #2599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Enhancement
politas
added a commit
that referenced
this pull request
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If you open a typical application, make changes, and then quit without saving, you're prompted to confirm that you really want to quit. This is done to prevent the user from losing work and having to re-do it if they click the quit button accidentally.
If you open CKAN, select mods to install or uninstall, and then quit without applying changes, it just closes.
Changes
Now if you select changes and try to quit, you get one of three prompts depending on whether there are conflicts or unmet dependencies. Clicking Yes closes CKAN, while clicking No closes the dialog and leaves CKAN running.
To avoid prompting unnecessarily after a successful installation, we now clear the change set after a successful installation. Previously we were leaving the change set intact (in the
Main.ChangeSetvariable) but hiding the change set tab and disabling the apply changes button, which ordinarily are side effects of clearing the change set. This put the application into a bit of an inconsistent state which clearing the change set avoids.