Fix crash on selecting filtered-out provider module #2585
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you:
... then you'll get a crash:
Cause
Apparently
row.DataGridView
is null here if the row isn't visible:CKAN/GUI/GUIMod.cs
Lines 279 to 286 in c4f067b
WinForms loves surprises.
Changes
Now the crash no longer occurs.
We will just skip those calls if the reference is null. This should be fine as they were just added to force the checkbox to refresh in visible rows, and it's not necessary for invisible ones, as they seem to be re-initialized upon becoming visible.
Fixes #2584.