Remove newline from Done progress message #2580
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I may be the only person bothered by this, but if you install mods in GUI, at the end the label above the progress bar says "(Done!" without a close parenthesis:
(I think you may even be able to see some of the rest of the message wrapped onto the next line in Mono.)
Cause
There's a
"\r\n"
in theRaiseProgress
message at the end of the install flow:CKAN/Core/ModuleInstaller.cs
Line 235 in e5fc437
GUI inserts this string into the middle of a larger formatted string, which is then split in half at that point:
CKAN/GUI/GUIUser.cs
Line 40 in e5fc437
CKAN/GUI/MainWait.cs
Lines 99 to 102 in e5fc437
The newline was probably included to make installing via CmdLine look better.
Changes
Now that newline sequence is removed and the close parenthesis appears:
A newline is added to the CmdLine install code to make it look the same as before.