Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up popup positioning in GUI #2544

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

HebaruSan
Copy link
Member

Background

If a KSP update happens, CKAN will alert you at launch:

image

This window can also be accessed via the menus, Settings ⇒ Compatible KSP Versions.

Problems

  • If it auto-opens at launch, this window will be positioned at the upper left corner of your leftmost monitor, which makes it difficult to notice
  • A Save button normally saves something without closing, but this one closes the window
  • Capitalization of "Ksp" in the title is wrong because it's an acronym standing for Kerbal Space Program
  • If the user opens this window manually and then cancels out, the mod list is regenerated needlessly

Changes

  • The window will be centered on the screen at startup
  • The window will be centered on its parent if the user opens it manually
  • The Save button now says Accept instead, to make it clearer that it closes the window
  • "KSP" is now all caps
  • There's a Close X button in the toolbar
  • The mod list is only regenerated if the user clicks Accept

image

Other changes:

  • The Select KSP Install window will now be centered on screen at startup
  • The Select KSP Install window will now be centered on its parent if the user opens it manually

@HebaruSan HebaruSan added Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request labels Oct 21, 2018
@politas politas merged commit d2b74d1 into KSP-CKAN:master Oct 23, 2018
politas added a commit that referenced this pull request Oct 23, 2018
@HebaruSan HebaruSan deleted the fix/popup-positions branch October 23, 2018 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants