Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
In a dark theme, the status log and parts of the mod info pane feature dark text on a dark background:
Looks fine in a normal theme:
Causes
WindowText
(black) onWindow
(white), but if you set itsReadOnly=true
, as we do in this case, the background is changed toControl
(dark gray) without changing the foreground, to give it a disabled appearanceForeColor
of the mod info pane labels toControlDarkDark
; the meaning of this value is:Gets a Color structure that is the dark shadow color of a 3-D element.
This color is not meant to be used for text foreground colors, and using it assumes a light background color.
Changes
Now these places look better.
ForeColor
is nowControlText
, to match its background.ForeColor
ofGrayText
, which the spec defines as "Gets a Color structure that is the color of dimmed text." This is meant to be used as a text color, and it will provide visual distinction from the normal text color:Standard themes still look OK:
Somewhat related to #2525 but not a fix for the specific things in that issue.