Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Discord RPC #1765

Merged
merged 1 commit into from
Aug 10, 2024
Merged

Improve Discord RPC #1765

merged 1 commit into from
Aug 10, 2024

Conversation

nexpid
Copy link
Contributor

@nexpid nexpid commented Aug 8, 2024

Cleans up the Discord RPC and makes the timestamp/timer accurate to the currently playing track.

Some notes:

2024-08-08.23-07-50.mp4

Current RPC for comparison:
current spotube Discord RPC

Copy link

@xhyrom xhyrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, i can work on the activity types tomorrow ;)

@KRTirtho
Copy link
Owner

KRTirtho commented Aug 9, 2024

It works great. Awesome work ❤️

But there are some unrelated changes that were submitted. Also there's a merge conflict Can you please fix these?

@KRTirtho KRTirtho self-requested a review August 9, 2024 14:23
Copy link
Owner

@KRTirtho KRTirtho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unrelated changes. We only need the discord_provider.dart's changes.

@nexpid
Copy link
Contributor Author

nexpid commented Aug 10, 2024

Please remove the unrelated changes. We only need the discord_provider.dart's changes.

The current win32 dependency is outdated and building on Windows machines does not work unless it's updated, that's why I updated all deps

@nexpid nexpid closed this Aug 10, 2024
@nexpid nexpid reopened this Aug 10, 2024
@nexpid nexpid requested a review from KRTirtho August 10, 2024 09:08
@nexpid
Copy link
Contributor Author

nexpid commented Aug 10, 2024

Please also review @xhyrom's KRTirtho/frb_plugins#1 PR, so I can add its activity type feature to this PR

@KRTirtho
Copy link
Owner

You should add that in a separate PR. I'll merge this PR now as it is working and link it to appropriate issues

@KRTirtho
Copy link
Owner

Actually, that's a really small change, I can add it by myself. Thanks for your PR!

@KRTirtho KRTirtho merged commit 64d2550 into KRTirtho:dev Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants