Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Visual C++ 2015-2022 Redistributable if missing when installing on Windows #1208

Merged
merged 1 commit into from
Feb 18, 2024

Conversation

olivier2
Copy link
Contributor

@olivier2 olivier2 commented Feb 5, 2024

Fixes #1191 ( discussions #549 and #1200 )

Makefile now clones https://github.com/DomGries/InnoDependencyInstaller

Using custom Inno setup config as per https://distributor.leanflutter.dev/makers/exe/#custom-inno-setup-template

Tested under Windows Sandbox
vc-redist-sandbox

@KRTirtho
Copy link
Owner

Wow, that's an awesome addition. It will help people who aren't familiar with vcredist.
Thanks for the contribution, I'll check it asap ❤️

@KRTirtho KRTirtho self-requested a review February 18, 2024 17:20
@KRTirtho KRTirtho added Windows Windows related issue enhancement New feature or request labels Feb 18, 2024
@KRTirtho KRTirtho linked an issue Feb 18, 2024 that may be closed by this pull request
2 tasks
Copy link
Owner

@KRTirtho KRTirtho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@KRTirtho KRTirtho merged commit ba69496 into KRTirtho:dev Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Windows Windows related issue
Projects
Status: Deployed
Development

Successfully merging this pull request may close these issues.

VCRUNTIME_1.dll was not found when i m installing in windows
2 participants