Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spotube uses incorrect values for MPRIS position property #1521

Closed
1 of 2 tasks
AlephNought0 opened this issue May 23, 2024 · 3 comments
Closed
1 of 2 tasks

Spotube uses incorrect values for MPRIS position property #1521

AlephNought0 opened this issue May 23, 2024 · 3 comments
Labels
bug Something isn't working Linux Linux related issue

Comments

@AlephNought0
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Spotube currently uses QVariant(qlonglong) for position property which makes it unable to fetch the proper position of the current playing media on Spotube.

Expected Behavior

Spotube should send the value of the property according to the freedesktop specifications. Mpris:Position is not a variant. See more here.
https://specifications.freedesktop.org/mpris-spec/latest/Player_Interface.html#Property:Position

Steps to reproduce

  1. Open Spotube
  2. Try fetching Mpris position property from Spotube using playerctl or other means.
  3. The returned value does not reflect the actual position of the media

Operating System

Linux, NixOS

Spotube version

v3.6.0

Installation source

GitHub Releases (Binary)

Additional information

No response

Self grab

  • I'm ready to work on this issue!
@AlephNought0 AlephNought0 added the bug Something isn't working label May 23, 2024
@KRTirtho KRTirtho added the Linux Linux related issue label Jul 9, 2024
@KRTirtho
Copy link
Owner

KRTirtho commented Jul 9, 2024

That's a great finding. I think we've to just change the datatype to Time_in_Us

@KRTirtho KRTirtho moved this to Discussion in Spotube Board Jul 9, 2024
@KRTirtho
Copy link
Owner

KRTirtho commented Jul 9, 2024

Actually, we are using a library audio_service_mpris that implements the DBus interface for MediaPlayer2. So, it was sending the wrong types. Now, they've updated to freedesktop specifications. So it's just simple library update.

@KRTirtho KRTirtho moved this from Discussion to In progress in Spotube Board Jul 9, 2024
@AlephNought0
Copy link
Author

Actually, we are using a library audio_service_mpris that implements the DBus interface for MediaPlayer2. So, it was sending the wrong types. Now, they've updated to freedesktop specifications. So it's just simple library update.

That's great to hear!

@KRTirtho KRTirtho moved this from In progress to Done in Spotube Board Jul 9, 2024
@KRTirtho KRTirtho moved this from Done to Deployed in Spotube Board Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Linux Linux related issue
Projects
Status: Deployed
Development

No branches or pull requests

2 participants