Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: deprecate CType meta schema draft-01 #778

Merged
merged 3 commits into from
Jul 13, 2023

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Jul 5, 2023

fixes KILTProtocol/ticket#2379

Prints a deprecation message if CTypes following the legacy meta schema are being used.
Also adjusts the default log level in non-production environments so that these messages are actually shown.

How to test:

Unit tests now started printing these deprecation messages.

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)
    • Either PR or Ticket to update the Docs
    • Link the PR/Ticket here

@rflechtner rflechtner self-assigned this Jul 5, 2023
@rflechtner rflechtner marked this pull request as ready for review July 5, 2023 14:25
@rflechtner rflechtner merged commit 5be1875 into develop Jul 13, 2023
@rflechtner rflechtner deleted the rf-deprecate-old-schema branch July 13, 2023 13:26
rflechtner added a commit that referenced this pull request Jul 26, 2023
* feat: deprecate CType meta schema draft-01
* fix: default to log level warn in non-production environments
rflechtner added a commit that referenced this pull request Aug 3, 2023
* feat: deprecate CType meta schema draft-01
* fix: default to log level warn in non-production environments
rflechtner added a commit that referenced this pull request Aug 3, 2023
* feat: deprecate CType meta schema draft-01
* fix: default to log level warn in non-production environments
rflechtner added a commit that referenced this pull request Aug 3, 2023
* feat: deprecate CType meta schema draft-01
* fix: default to log level warn in non-production environments
rflechtner added a commit that referenced this pull request Aug 22, 2023
* refactor!: nest ctype in ICTypeDetails (#766)
* refactor: change ctype parameter name to cType where possible

* feat: re-export imported types from @kiltprotocol/types (#762)
* feat: deprecate CType meta schema draft-01 (#778)

* fix: default to log level warn in non-production environments

* test: skip expensive delegation node tests
* test: esm variant of integration tests (#779)
* test: make tests work with new kilt node cli (#796)
* chore: update metadata to 1.11.0
* chore(deps): update cbor-web to v9
* chore(deps-dev): bump webpack from 5.70.0 to 5.76.0 (#771)
* chore(deps-dev): bump semver-regex from 3.1.3 to 3.1.4 (#775)
* chore(deps-dev): bump typedoc to resolve dependency conflict
* ci: make latest-develop tests optional and latest mandatory

Co-authored-by: Gerawork Aynekulu <[email protected]>
Co-authored-by: Raphael Flechtner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants