Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cbor-web replaces cbor #754

Merged
merged 1 commit into from
May 23, 2023
Merged

feat: cbor-web replaces cbor #754

merged 1 commit into from
May 23, 2023

Conversation

arty-name
Copy link
Collaborator

@arty-name arty-name requested a review from rflechtner May 17, 2023 14:41
@arty-name arty-name force-pushed the cbor-web_replaces_cbor branch from 916e149 to 590a232 Compare May 17, 2023 14:44
rflechtner
rflechtner reviewed May 22, 2023
View reviewed changes
packages/did/src/cbor-web.d.ts
@@ -0,0 +1 @@
declare module 'cbor-web'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm debating - is an empty declaration file better than a @ts-expect-error in front of the import? The result is the same - it's treated as any

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, I guess there is also an option to keep cbor as a dependency and make this module definition re-export the actual cbor types. This should be doable, though I doubt I will pull it off quickly.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that's the solution, this way we'll still keep the dependency on cbor - extracting type definitions from another package and adding it to your build is not really what tsc is made for I think

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also it wouldn't really help us much with anything, we're just importing two functions and do not plan to re-export them, there's not that much we can do wrong

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here’s a thing by the way

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And its discussion

rflechtner
rflechtner approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just not the biggest fan of empty declaration files, purely for aesthetical reasons

@arty-name arty-name force-pushed the cbor-web_replaces_cbor branch from fdfe30f to 5d7980d Compare May 23, 2023 11:23
@arty-name arty-name merged commit d630a42 into develop May 23, 2023
@arty-name arty-name deleted the cbor-web_replaces_cbor branch May 23, 2023 11:38
rflechtner pushed a commit that referenced this pull request May 24, 2023
@arty-name @rflechtner
feat: cbor-web replaces cbor (#754)
05f17e4
@rflechtner rflechtner mentioned this pull request Jun 8, 2023
Merged
rflechtner pushed a commit that referenced this pull request Jul 26, 2023
@arty-name @rflechtner
feat: cbor-web replaces cbor (#754)
91187db
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rflechtner rflechtner rflechtner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arty-name @rflechtner