ci: update GitHub workflows #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 436bca8.
ggera
approved these changes
Apr 4, 2023
| @@ -123,22 +124,20 @@ jobs: | |||
| continue-on-error: ${{ matrix.required == 'optional' }} | |||
|
|
|||
| steps: | |||
| - name: Log out node version | |||
| run: node --version | |||
| - name: Use Node.js 14 | |||
| uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 14 | |||
There was a problem hiding this comment.
Suggested change
| node-version: 14 | |
| node-version: 16 |
| @@ -123,22 +124,20 @@ jobs: | |||
| continue-on-error: ${{ matrix.required == 'optional' }} | |||
|
|
|||
| steps: | |||
| - name: Log out node version | |||
| run: node --version | |||
| - name: Use Node.js 14 | |||
| uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 14 | |||
There was a problem hiding this comment.
Suggested change
| node-version: 14 | |
| node-version: 16 |
| @@ -175,15 +174,15 @@ jobs: | |||
| uses: actions/setup-node@v3 | |||
| with: | |||
| node-version: 14 | |||
There was a problem hiding this comment.
Suggested change
| node-version: 14 | |
| node-version: 16 |
I haven't actually updated the node version of our build/test jobs, just the actions that were still using node v12. I'd do that in a separate PR so it's easier to revert if something breaks. |
rflechtner
added a commit
that referenced
this pull request
May 23, 2023
rflechtner
added a commit
that referenced
this pull request
May 23, 2023
rflechtner
added a commit
that referenced
this pull request
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re/ KILTProtocol/ticket#2264
Updates GitHub workflows to no longer use deprecated actions and features which will be retired shortly.
How to test:
Run as many workflows as possible I guess.
Checklist: