Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add authentication key requirement for didLookup pallet calls #509

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Mar 22, 2022

The DID logic did not include any DID key for the didLookup pallet, which accepts a DID origin with an authentication key.

How to test

Use "@kiltprotocol/sdk-js": "0.26.1-beta.1" against a version of the node that has the fixed origin, e.g., KILTprotocol/kilt-node#343.

@ntn-x2 ntn-x2 added 🐛 bug priority: bug ❤️ high priority: high labels Mar 22, 2022
@ntn-x2 ntn-x2 requested review from tjwelde and rflechtner March 22, 2022 08:15
@ntn-x2 ntn-x2 self-assigned this Mar 22, 2022
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! LGTM

@ntn-x2 ntn-x2 merged commit 5ed62d6 into master Mar 22, 2022
@ntn-x2 ntn-x2 deleted the aa-did-lookup-fix branch March 22, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug priority: bug ❤️ high priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants