Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump node types #499

Merged
merged 2 commits into from
Mar 16, 2022
Merged

fix: bump node types #499

merged 2 commits into from
Mar 16, 2022

Conversation

rflechtner
Copy link
Contributor

@rflechtner rflechtner commented Mar 15, 2022

fixes #497

Bumps @types/node in our lock file to a version that includes global definitions for URL and removes these definitions from our repo. This is to avoid conflicts between declarations as typescript does not simply merge these.
SDK consumers for whom this creates issues should either update their node types, make a global declaration in their own project or disable dependency type checks.

How to test:

N/A

Checklist:

  • I have verified that the code works
  • I have verified that the code is easy to understand
    • If not, I have left a well-balanced amount of inline comments
  • I have left the code in a better state
  • I have documented the changes (where applicable)

@rflechtner rflechtner self-assigned this Mar 15, 2022
@rflechtner rflechtner requested review from ntn-x2 and tjwelde March 15, 2022 08:30
Copy link
Member

@ntn-x2 ntn-x2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does look good to me, but would like for @tjwelde to double-check this.

@tjwelde
Copy link
Contributor

tjwelde commented Mar 16, 2022

yeah, hope they keep it in this time.
Since this concerns mostly new projects, I think it is fine to merge it like this. Projects with lock files will not be affected until they upgrade and upgrading already needs work to resolve conflicts.

@rflechtner rflechtner merged commit 6053995 into master Mar 16, 2022
@rflechtner rflechtner deleted the cp-node-global-declaration branch March 16, 2022 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants