Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update polkadot dependencies to latest #483

Merged
merged 9 commits into from
Mar 4, 2022
Merged

Conversation

ntn-x2
Copy link
Member

@ntn-x2 ntn-x2 commented Mar 3, 2022

Update polkadot dependencies to latest and fixes the consequent typescript error according to https://polkadot.js.org/docs/api/FAQ/#since-upgrading-to-the-7x-series-typescript-augmentation-is-missing.

Fixes https://github.com/KILTprotocol/ticket/issues/1870.

In short:

  • adds a import '@polkadot/api-augment' to the index.ts of each package (there might be a better way, but I would suggest to investigate that as part of the next release cycle)
  • updates the mocks to compile with the latest version
  • updates integration tests to run against latest-master and not latest-rc

How to test

Start a new project from scratch and import @kiltprotocol/[email protected], which matches the version in this PR.

@ntn-x2 ntn-x2 requested a review from tjwelde March 3, 2022 14:28
@ntn-x2 ntn-x2 self-assigned this Mar 3, 2022
@ntn-x2 ntn-x2 added dependencies Pull requests that update a dependency file ❤️ high priority: high labels Mar 3, 2022
@ntn-x2 ntn-x2 force-pushed the aa-polkadot-deps-fix branch from 8560d72 to de46d58 Compare March 3, 2022 14:46
Copy link
Contributor

@tjwelde tjwelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ntn-x2 ntn-x2 merged commit e591a4c into master Mar 4, 2022
@ntn-x2 ntn-x2 deleted the aa-polkadot-deps-fix branch March 4, 2022 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ❤️ high priority: high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants