fix: reject subscription promise on disconnect #479
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/KILTprotocol/ticket/issues/1835
To avoid tx status & event subscription to go stale or miss important updates (like finalisation), this makes sure that they are rejected on disconnect. Users would then have to go and check on chain if their transactions were successful by checking the desired effects.
How to test:
Using a test chain, make a transaction, submit it via the Blockchain helpers and interrupt the connection after receiving the
isReady
status update (e.g. by switching wifi off).Checklist: