Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework workshop to use new SDK methods #306

Merged
merged 28 commits into from
Apr 17, 2024
Merged

Rework workshop to use new SDK methods #306

merged 28 commits into from
Apr 17, 2024

Conversation

ChrisChinchilla
Copy link
Contributor

fixes KILTProtocol/ticket#3130

Changes workshop to use simpler createFromAccount method for DID creation.

@ChrisChinchilla
Draft
1213e05 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Copy link
Contributor Author

@rflechtner and @Ad96el A lot is still needed here from a reorganising perspective (it removes so much, which I will put elsewhere), but initially, are the createFromAccount changes correct?

@ChrisChinchilla
Factor into tests
3156664 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Update docs
9daa9a3 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Lint
b2b37ba 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Draft
802d3ab 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla ChrisChinchilla force-pushed the 3130-add-the-new-dispatchas-function-in-the-documentation branch 3 times, most recently from 8f1bbf3 to baa5060 Compare March 28, 2024 15:37
@ChrisChinchilla ChrisChinchilla marked this pull request as ready for review March 28, 2024 15:41
@ChrisChinchilla ChrisChinchilla changed the title Draft Rework wrokshop to use new SDK methods Mar 28, 2024
@ChrisChinchilla ChrisChinchilla changed the title Rework wrokshop to use new SDK methods Rework workshop to use new SDK methods Mar 28, 2024
@ChrisChinchilla ChrisChinchilla force-pushed the 3130-add-the-new-dispatchas-function-in-the-documentation branch from baa5060 to 838ddae Compare April 2, 2024 11:01
@ChrisChinchilla
Lint
3bb9568 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Update dependencies
90dc96e 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Revert
2e030ec 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla ChrisChinchilla force-pushed the 3130-add-the-new-dispatchas-function-in-the-documentation branch from 838ddae to 2e030ec Compare April 2, 2024 11:27
@ChrisChinchilla
Update docs
02b7db9 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Copy link
Contributor Author

@rflechtner Ready for a re-review, the link checker is failing on an external link again that we can't control much…

rflechtner
rflechtner reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks solid, I just think that where we now have only one mnemonic instead of two (because attester account and attester did are the same) we should consolidate both env variables

code_examples/sdk_examples/src/workshop/attester/generateDid.ts Outdated Show resolved Hide resolved
code_examples/sdk_examples/src/workshop/attester/generateDid.ts Outdated Show resolved Hide resolved
code_examples/sdk_examples/src/workshop/attester/generateDid.ts Outdated Show resolved Hide resolved
code_examples/sdk_examples/src/workshop/attester/generateDid.ts Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/02_did.md Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
code_examples/sdk_examples/src/workshop/attester/attestCredential.ts Outdated Show resolved Hide resolved
@ChrisChinchilla
Respond to feedback
8b3022c 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Merge branch '3130-add-the-new-dispatchas-function-in-the-documentati…
ec8eb9c 
…on' of github.com:KILTprotocol/docs into 3130-add-the-new-dispatchas-function-in-the-documentation
@ChrisChinchilla
Draft
3087168 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Test
a1c2a2a 
Signed-off-by: Chris Chinchilla <[email protected]>
@aws-amplify-eu-central-1 AWS Amplify (eu-central-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-306.d3oeht7cvddn19.amplifyapp.com

@ChrisChinchilla ChrisChinchilla force-pushed the 3130-add-the-new-dispatchas-function-in-the-documentation branch from 38b4363 to 04f4fac Compare April 15, 2024 10:19
@ChrisChinchilla
Draft
2112d9d 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla ChrisChinchilla force-pushed the 3130-add-the-new-dispatchas-function-in-the-documentation branch from de54383 to 2112d9d Compare April 15, 2024 10:30
ChrisChinchilla and others added 4 commits April 15, 2024 12:31
@ChrisChinchilla
Merge branch 'master' into 3130-add-the-new-dispatchas-function-in-th…
742a679 
…e-documentation
@ChrisChinchilla
Prettier
75167da 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Merge branch '3130-add-the-new-dispatchas-function-in-the-documentati…
13d7fc7 
…on' of github.com:KILTprotocol/docs into 3130-add-the-new-dispatchas-function-in-the-documentation
@ntn-x2
Fix mnemonic vs seed confusion
77bb3b2
@ChrisChinchilla ChrisChinchilla force-pushed the 3130-add-the-new-dispatchas-function-in-the-documentation branch 3 times, most recently from 7623591 to 19b4706 Compare April 16, 2024 11:44
@ChrisChinchilla
Fixes!
c9454a2 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla ChrisChinchilla force-pushed the 3130-add-the-new-dispatchas-function-in-the-documentation branch from 19b4706 to c9454a2 Compare April 16, 2024 12:06
@ChrisChinchilla
Tweaks
f3338d3 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Copy link
Contributor Author

@rflechtner Ready for a final review, I can already see a lot of next steps tweaks…

rflechtner
rflechtner reviewed Apr 16, 2024
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me! I think we should align the Keypair typing with other such typings throughout the docs (which use the union of all key pair types that can be used on a DID document as of now). But no major complaints here!

code_examples/sdk_examples/src/dapp/dapp/04_attest_credential.ts Outdated Show resolved Hide resolved
code_examples/sdk_examples/src/workshop/attester/generateDid.ts Outdated Show resolved Hide resolved
code_examples/sdk_examples/src/workshop/attester/generateDid.ts Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/01_account.md Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/02_did.md Outdated Show resolved Hide resolved
@ChrisChinchilla
Copy link
Contributor Author

@rflechtner Some good catches, all resolved

@ChrisChinchilla
Merge branch '3130-add-the-new-dispatchas-function-in-the-documentati…
44c6d12 
…on' of github.com:KILTprotocol/docs into 3130-add-the-new-dispatchas-function-in-the-documentation

Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla ChrisChinchilla force-pushed the 3130-add-the-new-dispatchas-function-in-the-documentation branch 2 times, most recently from 6ef16a9 to 727dedc Compare April 17, 2024 11:15
@ChrisChinchilla
Update
d5e9dfd 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla ChrisChinchilla force-pushed the 3130-add-the-new-dispatchas-function-in-the-documentation branch from 727dedc to d5e9dfd Compare April 17, 2024 12:35
rflechtner
rflechtner approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@rflechtner rflechtner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably tidy up dead code before we merge, but if you want to do it afterwards I'm also happy

code_examples/sdk_examples/src/dapp/dapp/04_attest_credential.ts Outdated Show resolved Hide resolved
docs/develop/03_workshop/04_attester/01_account.md Outdated Show resolved Hide resolved
ChrisChinchilla and others added 3 commits April 17, 2024 16:17
@ChrisChinchilla @rflechtner
Update docs/develop/03_workshop/04_attester/01_account.md
d4f8c09 
Co-authored-by: Raphael Flechtner <[email protected]>
@ChrisChinchilla
Remove defunct function
db6a5f5 
Signed-off-by: Chris Chinchilla <[email protected]>
@ChrisChinchilla
Merge branch '3130-add-the-new-dispatchas-function-in-the-documentati…
1c53279 
…on' of github.com:KILTprotocol/docs into 3130-add-the-new-dispatchas-function-in-the-documentation
@ChrisChinchilla ChrisChinchilla merged commit 3bc23e9 into master Apr 17, 2024
6 checks passed
@ChrisChinchilla ChrisChinchilla deleted the 3130-add-the-new-dispatchas-function-in-the-documentation branch April 17, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rflechtner rflechtner rflechtner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChrisChinchilla @rflechtner @ntn-x2