Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better author choice #88

Merged
merged 5 commits into from
May 24, 2022
Merged

Better author choice #88

merged 5 commits into from
May 24, 2022

Conversation

LudovicDrtt
Copy link
Contributor

Show author choices only if the user is in at least one club

TB023
TB023 previously approved these changes Apr 4, 2022
@TB023 TB023 requested a review from bastienlc April 4, 2022 12:57
bastienlc
bastienlc previously approved these changes Apr 4, 2022
Copy link
Member

@bastienlc bastienlc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works; same can be done for posting comments.

@LudovicDrtt LudovicDrtt dismissed stale reviews from bastienlc and TB023 via 7108be7 April 19, 2022 17:05
@LudovicDrtt
Copy link
Contributor Author

I did the same for event posting and editing and comment posting. However for comment posting that move the button to the left, i was unsuccessful to apply style to correct that. Moreover comment posting seems buggy when the users belong to a club…

Copy link
Contributor

@TheoContentin TheoContentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to works, we must investigate comment posting

@LudovicDrtt LudovicDrtt merged commit 19acf11 into dev May 24, 2022
@LudovicDrtt LudovicDrtt deleted the better_author_choice branch May 24, 2022 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants