-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cxx-qt-lib: add member functions #416
Conversation
7faa330
to
75cb6a7
Compare
75cb6a7
to
b5866ec
Compare
25be770
to
bc277ee
Compare
f892c50
to
9be49c6
Compare
8d06694
to
dceff60
Compare
683a07e
to
31c770f
Compare
31df984
to
b4a7a2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One actual issue on the QUrl::query
implementaiton, the rest is mostly nitpicking or opinion-based.
You could consider using a Rust macro for all these _or_default
methods...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, a bit more minor stuff.
Overall, amazing work!
10fef8d
to
556d2fa
Compare
8a8489f
to
3a707c4
Compare
3a707c4
to
1db0d59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥳
Related to #55
Requires #412
Requires #419