Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support linking Qt as macOS framework #358

Merged
merged 1 commit into from
Nov 18, 2022
Merged

support linking Qt as macOS framework #358

merged 1 commit into from
Nov 18, 2022

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Nov 17, 2022

The CI changes are only for testing this branch; I'll remove those before merging so we don't have 2 more CI jobs to wait on.

@Be-ing Be-ing marked this pull request as draft November 17, 2022 17:36
@ahayzen-kdab
Copy link
Collaborator

The CI changes are only for testing this branch; I'll remove those before merging so we don't have 2 more CI jobs to wait on.

How about we switch macOS to use homebrew and the frameworks stuff ?

Then vcpkg is still tested with Windows builds, but it increases our testing coverage without additional CI time?

We then are able to test

  • Qt 5 vs Qt 6
  • gcc vs clang vs msvc
  • linux packages (ubuntu debs) vs vcpkg vs macOS homebrew frameworks

@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 17, 2022

vcpkg on macOS is our only test for linking Qt statically, so I want to keep that.

@ahayzen-kdab
Copy link
Collaborator

vcpkg on macOS is our only test for linking Qt statically, so I want to keep that.

ah good point, Windows is still dynamic with vcpkg ? So maybe it would be another running we could have ...

So maybe in the future we might want a MinGW and a homebrew runner. 🤔

@Be-ing
Copy link
Contributor Author

Be-ing commented Nov 17, 2022 •
edited
Loading

Windows is still dynamic with vcpkg ?

For now, yes, though I do want to change that to deal with #224.

@ahayzen-kdab
Copy link
Collaborator

Windows is still dynamic with vcpkg ?

For now, yes, though I do want to change that to deal with #224.

Right, so if Windows moved to static vcpkg and homebrew works. Then we could potentially move the macOS runners over.

@Be-ing Be-ing force-pushed the apple_framework branch 3 times, most recently from 0e15a25 to d159457 Compare November 17, 2022 20:01
@Be-ing Be-ing marked this pull request as ready for review November 17, 2022 20:21
ahayzen-kdab
ahayzen-kdab approved these changes Nov 18, 2022
View reviewed changes
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :-)

@ahayzen-kdab ahayzen-kdab merged commit c6ac928 into KDAB:main Nov 18, 2022
@Be-ing Be-ing deleted the apple_framework branch November 18, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahayzen-kdab ahayzen-kdab ahayzen-kdab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @ahayzen-kdab