Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add example application built entirely with Cargo #221

Merged
merged 5 commits into from
Aug 26, 2022

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Aug 25, 2022

🦀

image

@Be-ing Be-ing force-pushed the full_cargo_build branch 3 times, most recently from a60bd45 to b23abe6 Compare August 26, 2022 01:29
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but for me it fails to link to Qt ...

@Be-ing Be-ing force-pushed the full_cargo_build branch 5 times, most recently from ef5ea62 to a81b2fd Compare August 26, 2022 03:05
@Be-ing Be-ing force-pushed the full_cargo_build branch 4 times, most recently from e6f5b2d to 33c1d02 Compare August 26, 2022 04:10
Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, reported #223 and #224 as issue to look at later.

@ahayzen-kdab ahayzen-kdab merged commit 8ced9b5 into KDAB:main Aug 26, 2022
@LeonMatthesKDAB
Copy link
Collaborator

As a follow-up:
Do we want to replace qml_minimal with this?
Then we don't have to maintain what's basically the same code twice?
Or could we even have qml_minimal with two separate build scripts, one for building with CMake and one without?

@ahayzen-kdab
Copy link
Collaborator

ahayzen-kdab commented Aug 26, 2022

As a follow-up: Do we want to replace qml_minimal with this? Then we don't have to maintain what's basically the same code twice? Or could we even have qml_minimal with two separate build scripts, one for building with CMake and one without?

I think we probably want both as they are different use cases. One is showing the minimum to integrate a Rust QML module into a CMake C++ project. And the other is showing the minimum to create a from scratch Rust QML module building with cargo. And as the cargo build has some issues still the qml_minimal one is a good example for the book etc.

@LeonMatthesKDAB
Copy link
Collaborator

Right, I'm just wondering whether we can reduce the code duplication for the actual src code.
Could we symlink e.g. src/cxxqt_object.rs and main.qml to the qml_minimal ones?

@Be-ing Be-ing deleted the full_cargo_build branch August 26, 2022 10:56
@Be-ing
Copy link
Contributor Author

Be-ing commented Aug 26, 2022

Symlinking the duplicated files is implemented in #226

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants