Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cxx-qt-gen: use namespace = "A::B" from cxx_qt::bridge #194

Merged
merged 3 commits into from
Aug 8, 2022

Conversation

ahayzen-kdab
Copy link
Collaborator

Requires #193

Note that currently each QObject must be in it's own namespace otherwise free functions will collide. This will be improved in the future.

@ahayzen-kdab ahayzen-kdab force-pushed the use-namespace-properly branch from 6df8ca6 to fb9a758 Compare August 8, 2022 17:44
@ahayzen-kdab ahayzen-kdab marked this pull request as ready for review August 8, 2022 17:44
@ahayzen-kdab ahayzen-kdab force-pushed the use-namespace-properly branch from fb9a758 to d1e2411 Compare August 8, 2022 17:49
@ahayzen-kdab ahayzen-kdab force-pushed the use-namespace-properly branch from d1e2411 to c6d3e25 Compare August 8, 2022 18:07
Note that currently each QObject must be in it's own namespace
otherwise free functions will collide. This will be improved
in the future.
@ahayzen-kdab ahayzen-kdab force-pushed the use-namespace-properly branch from c6d3e25 to e69d592 Compare August 8, 2022 18:53
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay removing code 🎉

@ahayzen-kdab ahayzen-kdab enabled auto-merge (rebase) August 8, 2022 19:04
@ahayzen-kdab ahayzen-kdab merged commit 20ec236 into KDAB:main Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants