-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cxx-qt-gen: use namespace = "A::B" from cxx_qt::bridge #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
Aug 5, 2022
5d5c0c8
to
08b1ff2
Compare
53 tasks
08b1ff2
to
6df8ca6
Compare
ahayzen-kdab
commented
Aug 5, 2022
6df8ca6
to
fb9a758
Compare
fb9a758
to
d1e2411
Compare
Be-ing
reviewed
Aug 8, 2022
d1e2411
to
c6d3e25
Compare
Be-ing
reviewed
Aug 8, 2022
Be-ing
reviewed
Aug 8, 2022
Be-ing
reviewed
Aug 8, 2022
Note that currently each QObject must be in it's own namespace otherwise free functions will collide. This will be improved in the future.
c6d3e25
to
e69d592
Compare
Be-ing
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yay removing code 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #193
Note that currently each QObject must be in it's own namespace otherwise free functions will collide. This will be improved in the future.