-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cxx-qt-gen: use impl cxx_qt::QObject<T> block for invokables #178
cxx-qt-gen: use impl cxx_qt::QObject<T> block for invokables #178
Conversation
@LeonMatthesKDAB did we decide if we were going to call this |
So i'm wondering if this is the route (assuming valid syntax) impl cxx_qt::invokables<MyObject> {
#[invokable]
pub fn my_invokable(self: Pin<&mut Self>) {
}
}
impl MyObject {
pub fn rust_only_method(&self) {
}
} @LeonMatthesKDAB where did our discussion end up on having like |
b11a3e8
to
b1f6009
Compare
We shouldn't use But regarding the
I'm unsure whether we reached a consensus on that or whether we were still just discussing options 🤔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going in the right direction. A bit of clarification regarding the purposes of impl Qt<...>
vs impl ...
are still necessary :)
e47236e
to
c4d0ee7
Compare
35ee3ca
to
450abae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one typo, then we're good to go :)
This helps later as the invokables are implemented onto a different struct, so this clearly defines the split between C++ and Rust methods etc.
450abae
to
ec9f655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This helps later as the invokables are implemented onto a different
struct, so this clearly defines the split between C++ and Rust
methods etc.