Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gen_rs: pass through ForeignMod to the CXX bridge for now #164

Merged
merged 2 commits into from
Jul 21, 2022
Merged

gen_rs: pass through ForeignMod to the CXX bridge for now #164

merged 2 commits into from
Jul 21, 2022

Conversation

ahayzen-kdab
Copy link
Collaborator

Later we will pass through all non CXX-Qt items to the CXX bridge,
but this is a stepping stone that allows us to progress.

@ahayzen-kdab ahayzen-kdab mentioned this pull request Jul 20, 2022
Closed
53 tasks
@ahayzen-kdab
Copy link
Collaborator Author

This doesn't work with unsafe extern "C++" ...

@ahayzen-kdab
Copy link
Collaborator Author

This doesn't work with unsafe extern "C++" ...

So extern "T" comes through as ItemForeegnMod but unsafe extern "T" comes through as Verbatim.

@ahayzen-kdab ahayzen-kdab force-pushed the pass-through-extern-blocks branch 2 times, most recently from 5bb7019 to 1adfc17 Compare July 21, 2022 10:02
@ahayzen-kdab
Copy link
Collaborator Author

This doesn't work with unsafe extern "C++" ...

So extern "T" comes through as ItemForeegnMod but unsafe extern "T" comes through as Verbatim.

This works now.

Just need to also support attributes on the extern block.

@ahayzen-kdab
Copy link
Collaborator Author

Just need to also support attributes on the extern block.

This is working now

@ahayzen-kdab ahayzen-kdab mentioned this pull request Jul 21, 2022
Merged
@ahayzen-kdab ahayzen-kdab force-pushed the pass-through-extern-blocks branch from ba757c0 to f11a6b2 Compare July 21, 2022 16:49
Be-ing
Be-ing previously approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@Be-ing Be-ing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waiting for CI

@ahayzen-kdab
gen_rs: pass through ForeignMod to the CXX bridge for now
71213a0 
Later we will pass through all non CXX-Qt items to the CXX bridge,
but this is a stepping stone that allows us to progress.
@ahayzen-kdab
gen_rs: also pass through any attributes on the item
c7b60bf
@ahayzen-kdab ahayzen-kdab force-pushed the pass-through-extern-blocks branch from f11a6b2 to c7b60bf Compare July 21, 2022 16:59
@ahayzen-kdab
Copy link
Collaborator Author

(Rebased as the other one landed)

@Be-ing Be-ing merged commit 4a64e9b into KDAB:main Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Be-ing Be-ing Be-ing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahayzen-kdab @Be-ing