Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabbed widgets are only docked to main window #280

Closed
tlaemmlein opened this issue Mar 21, 2022 · 3 comments
Closed

Tabbed widgets are only docked to main window #280

tlaemmlein opened this issue Mar 21, 2022 · 3 comments
Assignees
@iamsergio

Comments

@tlaemmlein
Copy link

tlaemmlein commented Mar 21, 2022 •
edited
Loading

Hi,
System: Windows 10 / VS 2019
kddockwidgets version: 1.6.0 with bug fix: #96

Nandish mentions this already in #96 : The tabbed widgets are only docked to main window.

But isn't it more logical if the widget will be docked to the last dock position instead of the main window?

Image you have tabbed some tool widgets and you undock one of these tool to set something and then you want to dock it to the other tools again and not to the main window.

dock_location_is_only_main_window

Kind Regards,
Thomas
@iamsergio
Copy link
Contributor

FloatingWidgets don't keep "previous positions" yet, I agree it would be useful.
Some people however only want them in main windows (but could be configurable).
Hasn't been done since it's a big feature (or rather big change). Probably for 2.0

@iamsergio iamsergio self-assigned this Mar 29, 2022
@bbc131
Copy link
Contributor

bbc131 commented Dec 6, 2023

I just stumpled over this behavior when playing with the example and was going to file a bug issue.
Not a big issue, but clearly a bug, imho.
At least I was very surprised seeing a dockwidget docking in the main-window, after I just played with it in a floating-window.

iamsergio added a commit that referenced this issue Jul 10, 2024
@iamsergio
Add a test for FloatingWindow placeholders
77fffd6 
They currently lose if there's a competing main window placeholder.
Test is currently failing.

For issue #513 and #280
iamsergio added a commit that referenced this issue Jul 14, 2024
@iamsergio
Allow to redock back to a floating window placeholder
8f755bc 
When double-clicking on title-bar or using the unfloat button,
the dock widget should dock back to its previously known position
in the main window.

This is now also supported if its previous position was in
a floating window (nested)

Fixes #280
iamsergio added a commit that referenced this issue Jul 14, 2024
@iamsergio
Allow to redock back to a floating window placeholder
1934881 
When double-clicking on title-bar or using the unfloat button,
the dock widget should dock back to its previously known position
in the main window.

This is now also supported if its previous position was in
a floating window (nested)

Fixes #280
iamsergio added a commit that referenced this issue Jul 14, 2024
@iamsergio
Add a test for FloatingWindow placeholders
02b31e3 
They currently lose if there's a competing main window placeholder.
Test is currently failing.

For issue #513 and #280
iamsergio added a commit that referenced this issue Jul 14, 2024
@iamsergio
Allow to redock back to a floating window placeholder
9a38738 
When double-clicking on title-bar or using the unfloat button,
the dock widget should dock back to its previously known position
in the main window.

This is now also supported if its previous position was in
a floating window (nested)

Fixes #280
iamsergio added a commit that referenced this issue Jul 14, 2024
@iamsergio
Upload changelog for issue #280
cabdd8d
@iamsergio
Copy link
Contributor

This is done (main / 2.2)

@iamsergio iamsergio mentioned this issue Jul 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iamsergio iamsergio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@iamsergio @tlaemmlein @bbc131