-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow having bindings referencing const Properties #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change, do we really need the ConstPropertyNode class?
@phyBrackets Can you please rebase this and your other PRs. CI should then pass again :) Edit: Nevermind, I added the option to do it through Github, so can do it myself :) |
ec7f588
to
9fd60d1
Compare
Hm, enabling clazy seems to have generated some new warnings through this PR. Good thing that's actually now failing CI 🤔 Please fix them before this PR can be merged. |
So that is easy to fix, but we still want to see if we want the |
I definitely want to be able to reference const Properties, I just wonder why we need an entirely new Node type for this? Could you try modifying the existing PropertyNode type to accept const references? Or is there any reason it really has to be its own class? At the moment it just seems like a lot of code duplication... |
7994473
to
7ab22cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This already looks pretty good, but I think we can get away without the IsConst conditionals.
d3904fe
to
e80936e
Compare
e80936e
to
a74f98c
Compare
Initial work for issue #29