Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip if package already built #397

Merged
merged 1 commit into from
Dec 16, 2022

Conversation

agoose77
Copy link
Contributor

@agoose77 agoose77 commented Dec 16, 2022

hatch-jupyter-builder always runs by default, unless we set skip-if-exists

@agoose77
Copy link
Contributor Author

@artur-trzesiok The reason this PR is needed is because hatch-jupyter-builder runs a build by default, even if the SDist contains the k3d/labextension build output already. This PR changes that, by skipping the build if the k3d/labextension/package.json exists.

This is partly happening because we don't have to ship the compiled artefacts in the SDist; we could only ship the source, and require that the user has nodejs installed. This is my preferred approach to packaging, but in #395 (and #386) we explicitly include the generated files in the SDist.

What is your preferred solution here? Would you prefer smaller SDists that require compilation, or to ship the compiled JS?

@artur-trzesiok
Copy link
Collaborator

artur-trzesiok commented Dec 16, 2022

But sdist include compiled js. Please check my k3d-2.15.0.tar.gz :
filestructure.txt

And sdist is still in good size (9.5mb). I don't need to make in smaller. K3D is a python package so I don't want to force users to use nodejs

@artur-trzesiok
Copy link
Collaborator

I assume that after that merge we should deploy 2.15.1 to trigger conda-forge process

@artur-trzesiok artur-trzesiok merged commit 627bdbb into K3D-tools:main Dec 16, 2022
@agoose77
Copy link
Contributor Author

@artur-trzesiok yes, probably. Apologies for the confusion. Let me first confirm that this sdist doesn't require nodejs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants