Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nullability of connectGattCompat function #720

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Fix nullability of connectGattCompat function #720

merged 2 commits into from
Jul 26, 2024

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Jul 25, 2024

Was incorrectly marked as non-nullable, but connectGatt may return null.

@twyatt twyatt added the patch Changes that should bump the PATCH version number label Jul 25, 2024
@twyatt twyatt requested a review from a team as a code owner July 25, 2024 21:32
@twyatt twyatt enabled auto-merge (squash) July 26, 2024 18:37
@twyatt twyatt merged commit 475833b into main Jul 26, 2024
2 checks passed
@twyatt twyatt deleted the twyatt/connectGattCompat-nullable branch July 26, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaylor-juul davidtaylor-juul davidtaylor-juul approved these changes

@sdonn3 sdonn3 sdonn3 approved these changes

@QuantumRand QuantumRand Awaiting requested review from QuantumRand QuantumRand is a code owner automatically assigned from JuulLabs/conx-kotlin-reviewers

Assignees
No one assigned
Labels
patch Changes that should bump the PATCH version number
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twyatt @sdonn3 @davidtaylor-juul