Add --gdb argument for debugging #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotrnarajowski
force-pushed
the
add_gdb_arg
branch
2 times, most recently
from
2f01862 to
6ca9245
Compare
btptester.py
Outdated
| help='Stops the run at first failure'), | ||
| parser.add_argument('--gdb', type=str, | ||
| help="Skip selected board reset to avoid gdb server" | ||
| " disconnection e.g. --gdb central/prph/both") |
There was a problem hiding this comment.
Nitpick: I'd say, either use short or full names, so either central/peripheral or cent/perph
There was a problem hiding this comment.
Switched to short
This commit implements --gdb argument. Board reset will be skipped for central/peripheral/both when btptester.py is launched. This might be helpful for debugging.
This fixes access to uninitialized variable
piotrnarajowski
force-pushed
the
add_gdb_arg
branch
from
6ca9245 to
915d409
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements --gdb argument. Reset is skipped for central/peripheral/both board(s) when btptester.py is launched. This might be helpful for debugging. Also, in btptester.py added rerun_failed variable initialization. This fixes access to uninitialized variable