Adjust to upcoming world age change in Julia 1.12 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julia 1.12 will change where world age increments are being inserted implicitly. The expansion of `@constinferred` is relying on an implicit world age increment between `eval` and the subsequent evaluation, which may go away in 1.12. Add an explicit marker to force the increment to be retained here. This preserves existing behavior. It may be the case that an alternative world age mechanism (e.g. invokelatest) is more appropriate, but it's hard for me to evaluate without full context.
|
Thanks for this fix. The |
|
Could I get a version tagged with this PR? I'd like PkgEval to not complain about this package and its downstreams when I merge the upstream PR. |
|
Yes but I am not behind my computer right now. I will do so tonight or first thing tomorrow. |
|
No rush |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia 1.12 will change where world age increments are being inserted implicitly. The expansion of
@constinferredis relying on an implicit world age increment betweenevaland the subsequent evaluation, which may go away in 1.12. Add an explicit marker to force the increment to be retained here. This preserves existing behavior. It may be the case that an alternative world age mechanism (e.g. invokelatest) is more appropriate, but it's hard for me to evaluate without full context.