Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(here): Adding missing enum values on ResultType #72

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

Farthom
Copy link
Contributor

@Farthom Farthom commented Apr 13, 2023

The saga continues. I've encountered the following error:
Geo.Here.Models.Exceptions.HereException: Failed to parse the Here response properly. See the inner exception for more information. ---> Newtonsoft.Json.JsonSerializationException: Error converting value "postalCodePoint" to type 'Geo.Here.Enums.ResultType'. Path 'items[0].resultType', line 1, position 158. ---> System.ArgumentException: Requested value 'postalCodePoint' was not found.

The issue is due to the fact that there appears to be 4 valid response values not captured in the ResultType enum. I have added them in accordance with this document:
https://developer.here.com/documentation/geocoding-search-api/dev_guide/topics/result-types.html

@JustinCanton
Copy link
Owner

Hmmm, I wonder if it isn't more worth it to drop the enum and just use a string value instead. If new enum values keep getting added, this could break again.

For now, this looks good though.

@JustinCanton JustinCanton added this to the 1.5.0 milestone Apr 13, 2023
@JustinCanton JustinCanton added the bug Something isn't working label Apr 13, 2023
@JustinCanton JustinCanton self-requested a review April 13, 2023 15:28
@JustinCanton JustinCanton merged commit e7ed451 into JustinCanton:develop Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants