Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable includeReferrer in Amplitude init options #2397

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

shakao
Copy link
Contributor

@shakao shakao commented Sep 15, 2022

enabling url referrers in Amplitude, based on docs here: https://amplitude.github.io/Amplitude-JavaScript/Options

not quite sure how to test this since we don't include Amplitude in any of our local/dev builds... very open to ideas! maybe we should configure our demo sites to send events to a demo Amplitude project or something?

[sc-10936]

@shakao shakao requested a review from austensen September 15, 2022 19:10
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #10936: [Analytics] Enable URL referrer in LA TAC amplitude setup.

Copy link
Member

@austensen austensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I was thinking the same thing when working on amplitude for org site - I think that might be worthwhile to do for demo. I think it should be pretty straightforward to make new amplitude projects and just swap the code. Could be useful for times when we release the demo version for user testing too (like we did with wow when testing the new portfolio method).

@shakao shakao merged commit 5e3d598 into master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants