Add new, empty eviction free site. #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toolness
commented
Jan 11, 2021
| @@ -233,5 +233,8 @@ export function getAmplitudePageType(pathname: string): string { | |||
| return "JustFix " + getJustfixPageType(pathname); | |||
| case "NORENT": | |||
| return "NoRent " + getNorentPageType(pathname); | |||
| case "EVICTIONFREE": | |||
| // TODO: Return the type of page it is for EvictionFree. | |||
| return "EvictionFree"; | |||
There was a problem hiding this comment.
We should file a github or clubhouse issue for this to make sure we don't forget about it.
toolness
commented
Jan 11, 2021
|
|
||
| case "EVICTIONFREE": | ||
| // TODO: Need to figure out if we need separate terms for EvictionFree! | ||
| return s.onboardingInfo.agreedToJustfixTerms; |
There was a problem hiding this comment.
We should file a github or clubhouse issue for this to make sure we don't forget about it.
toolness
commented
Jan 11, 2021
| @@ -41,6 +41,9 @@ function getSiteBaseName(siteType: SiteChoice): string { | |||
|
|
|||
| case "NORENT": | |||
| return "NoRent.org"; | |||
|
|
|||
| case "EVICTIONFREE": | |||
| return "EvictionFree.org"; | |||
There was a problem hiding this comment.
We may need to change this based on what our final domain name is, so we should file an issue to address this later.
toolness
commented
Jan 11, 2021
|
|
||
| case "EVICTIONFREE": | ||
| // TODO: Figure out if we need a separate privacy policy / terms for EvictionFree! | ||
| return baseURL; |
There was a problem hiding this comment.
Again, file an issue to address this later.
sraby
reviewed
Jan 11, 2021
Comment on lines
+1
to
+23
| import { createRoutesForSite, ROUTE_PREFIX } from "../util/route-util"; | ||
| import { createDevRouteInfo } from "../dev/route-info"; | ||
|
|
||
| function createLocalizedRouteInfo(prefix: string) { | ||
| return { | ||
| /** The locale prefix, e.g. `/en`. */ | ||
| [ROUTE_PREFIX]: prefix, | ||
|
|
||
| /** The home page. */ | ||
| home: `${prefix}/`, | ||
| }; | ||
| } | ||
|
|
||
| export const EvictionFreeRoutes = createRoutesForSite( | ||
| createLocalizedRouteInfo, | ||
| { | ||
| /** | ||
| * Example pages used in integration tests, and other | ||
| * development-related pages. | ||
| */ | ||
| dev: createDevRouteInfo("/dev"), | ||
| } | ||
| ); |
There was a problem hiding this comment.
Nice! loving the new route-info.ts name, makes it v clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a brand new site for us to build EFNYC 2.0 (NYS Declaration Letter) off of.
Currently the site is extremely barebones, to be fleshed out later:
The site can be visited by changing a Site object to have "evictionfree" in its name in the Django admin (this is similar to how we do things for norent).
What was done
A new entry for the new site was added to
site-choices.json. This effectively expands theSiteChoicetype, and thanks to exhaustive switch statements in TypeScript it means that a bunch of type errors will now pop up during typechecking if we don't handle the case where EvictionFree is the current site in a number of places in our code, including:An entry in
app.tsxthat returns the code-split bundle for EvictionFree's React Router JSX component if needed (using a code-split bundle is particularly important here, we don't want the entire EvictionFree codebase delivered to clients if they're viewing NoRent or app.justfix.nyc).An entry in
global-site-routes.tsthat returns EvictionFree'sRouteInfoif needed. (See the development guide section on routing for a refresher on whatRouteInfois.)A new entry to
amplitude.tsto provide a human-readable name for the site in Amplitude events.An entry in
page.tsxthat provides the name of the EvictionFree site for page titles.An entry in
privacy-info-modal.tsxthat links to the site-specific privacy policy on our org site.Logic in
site_util.pywas added to detect whether a DjangoSitemodel name corresponds to the EvictionFree site.A new SASS bundle was added at
frontend/sass/evictionfree/styles.scssto encapsulate all the styling for the new site; it's conditionally delivered to the client only if the current site being rendered is EvictionFree infrontend/templates/frontend/index.html. In order to actually generate the SASS bundle, we had to modifypackage.jsona bit. (Yes, this whole thing is a bit suboptimal.)An entry was added to
frontend/localebuilder/cli.tsto ensure that all localization strings that only appear in thefrontend/lib/evictionfreedirectory are put in their own message catalog JS bundle. This will ensure that if the user is visiting a different site like NoRent or app.justfix.nyc, they won't needlessly waste bandwidth on a bunch of localized strings that are specific to EvictionFree.This separate message catalog JS bundle is loaded in
frontend/lib/evictionfree/site.tsxas the root element of the EvictionFree site, ensuring that every page on the site has access to the EvictionFree-specific translations.