This repository has been archived by the owner on May 8, 2024. It is now read-only.
Fix setsettings, and cemu controller generation. Add additional controllers to es_input. #2820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing mkcontroller to search for the guid rather than the name breaks setsettings, as retroarch controls are found by name. Additionally, several controller guids were missing from EmulationStation's es_input.cfg, this is the beginning of that correction. More to come.
Type of change
How Has This Been Tested Locally?
Tested on Air Pro, Air Plus, Loki Zero, Loki Max, Ayaneo 2S, and Powkiddy RGB10 Max 3.
Note: This PR template is adapted from embeddedartistry